add file event handlers #2165
Merged
add file event handlers #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabime
requested changes
Nov 10, 2021
| @@ -14,7 +14,8 @@ namespace spdlog { | |||
| namespace sinks { | |||
|
|
|||
| template<typename Mutex> | |||
| SPDLOG_INLINE basic_file_sink<Mutex>::basic_file_sink(const filename_t &filename, bool truncate) | |||
| SPDLOG_INLINE basic_file_sink<Mutex>::basic_file_sink(const filename_t &filename, bool truncate, const file_event_handlers_t& event_handlers) | |||
| : file_helper_{std::move(event_handlers)} | |||
There was a problem hiding this comment.
const reference cannot be really moved
| @@ -68,10 +68,11 @@ class daily_file_sink final : public base_sink<Mutex> | |||
| { | |||
| public: | |||
| // create daily file sink which rotates on given time | |||
| daily_file_sink(filename_t base_filename, int rotation_hour, int rotation_minute, bool truncate = false, uint16_t max_files = 0) | |||
| daily_file_sink(filename_t base_filename, int rotation_hour, int rotation_minute, bool truncate = false, uint16_t max_files = 0, const file_event_handlers_t& event_handlers = {}) | |||
example/example.cpp
Outdated
| @@ -26,9 +26,32 @@ void custom_flags_example(); | |||
| #include "spdlog/spdlog.h" | |||
| #include "spdlog/cfg/env.h" // support for loading levels from the environment variable | |||
| #include "spdlog/fmt/ostr.h" // support for user defined types | |||
| #include "spdlog/common.h" | |||
|
|
|||
| spdlog::file_event_handlers_t file_event_handlers; | |||
There was a problem hiding this comment.
file_event_handlers is referenced by other example functions.
There was a problem hiding this comment.
I prefer not to change the original example functions and keep it simple. Lets just have single function in the end that shows how to use it.
There was a problem hiding this comment.
ok.
I have fixed that. Just pass file_event_handlers to the rotating_logger
example/example.cpp
Outdated
|
|
||
| spdlog::file_event_handlers_t file_event_handlers; | ||
|
|
||
| void init_file_event_handler() |
There was a problem hiding this comment.
please move this towards the end of example.cpp
|
Merged. Thanks @seker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add file event handlers