Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fopen_s error reporting with PREVENT_CHILD_FD #2305

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix fopen_s error reporting with PREVENT_CHILD_FD #2305

merged 1 commit into from
Mar 11, 2022

Conversation

nUl1
Copy link

@nUl1 nUl1 commented Mar 11, 2022

open() failure was incorrectly reported as a success under *nix with SPDLOG_PREVENT_CHILD_FD enabled, leaving *fp untouched.

@nUl1
Copy link
Author

nUl1 commented Mar 11, 2022

I've tried to provide a test for this but only checked it on Linux.

@gabime gabime merged commit b1478d9 into gabime:v1.x Mar 11, 2022
@gabime
Copy link
Owner

gabime commented Mar 11, 2022

Thanks @nUl1

@nUl1 nUl1 deleted the fix-fopens branch March 14, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nUl1 @gabime