Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1: Allow modifying the used Android buffer #2358

Merged
merged 2 commits into from
May 6, 2022
Merged

V1: Allow modifying the used Android buffer #2358

merged 2 commits into from
May 6, 2022

Conversation

tiolan
Copy link
Contributor

@tiolan tiolan commented May 6, 2022

Following up on #2352, but merging into v1.x

@tiolan
Copy link
Contributor Author

tiolan commented May 6, 2022

@gabime Please let me know if I should also create a PR for v2.x

include/spdlog/sinks/android_sink.h Outdated Show resolved Hide resolved
@gabime gabime merged commit a934701 into gabime:v1.x May 6, 2022
@gabime
Copy link
Owner

gabime commented May 6, 2022

Thanks @tiolan

@tiolan
Copy link
Contributor Author

tiolan commented May 24, 2022

@HelloWorldQIU any more background information on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants