Allow overriding need_localtime for custom formatter #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Need to fid the clone() function ad well. Any idea why tests fail? |
gabime
requested changes
May 7, 2022
| memory_buf_t formatted; | ||
| spdlog::details::log_msg msg(spdlog::source_loc{}, "logger-name", spdlog::level::info, "some message"); | ||
| formatter->format(msg, formatted); | ||
| REQUIRE(to_string_view(formatted) == oss.str()); |
There was a problem hiding this comment.
1.This can fail if the time changes when getting here
2. This fails on windows (eol is “\r\n”)
|
Thank you for fast feedback.
|
|
Thanks @conr2d . Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user wants to use the pattern with no builtin flags related to time, but custom formatter that needs time information, there is no way to make pattern_formatter pass the updated
const std::tm&toformat()of custom formatter. This PR allows user to overrideneed_localtimeso that custom formatter can utilize cached_tm with the pattern not enablingneed_localtimeby default.