Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove try_lock from null_mutex. #2385

Merged
merged 1 commit into from
May 20, 2022
Merged

Remove try_lock from null_mutex. #2385

merged 1 commit into from
May 20, 2022

Conversation

panzhongxian
Copy link
Contributor

Only std::unique_lock and std::lock_guard are used on member variable mutex_. Both of them should meet the BasicLockable requirements, which means lock() and unlock are enough.

@gabime gabime merged commit 9e8e52c into gabime:v1.x May 20, 2022
@gabime
Copy link
Owner

gabime commented May 20, 2022

Thanks @panzhongxian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@panzhongxian @gabime