Support compile-time format string checking with std::format #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabime
requested changes
Nov 11, 2022
gabime
reviewed
Nov 11, 2022
gabime
requested changes
Nov 12, 2022
|
|
||
| #ifndef SPDLOG_USE_STD_FORMAT | ||
| template<typename T, typename... Args> | ||
| inline fmt::basic_string_view<T> to_string_view(fmt::basic_format_string<T, Args...> fmt) |
There was a problem hiding this comment.
shouldn’t this be SPDLOG_CONSTEXPR_FUNC as well?
There was a problem hiding this comment.
No because the conversion operator for fmt::basic_format_string to fmt::basic_string_view is not constexpr
|
Merged.Thanks @sylveon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now std::format and fmtlib are equivalent when using spdlog with either.