Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #include to deprecated fmt header #2545

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Conversation

kromain
Copy link
Contributor

@kromain kromain commented Nov 11, 2022

The <fmt/locale.h> header has been marked as deprecated for a while and has finally been removed in fmt v0.9.0:
fmtlib/fmt@5c7d315

Replace with <fmt/format.h> instead, as recommended in the deprecated header.

The vcpkg build with the benchmark feature (./vcpkg install spdlog[core,benchmark]) is currently broken because of this:

[5/16] /usr/bin/c++ -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL -I/workspaces/vcpkg/buildtrees/spdlog/src/v1.10.0-3cbe543323/include -isystem /workspaces/vcpkg/installed/x64-linux/include -fPIC -g -std=c++11 -MD -MT bench/CMakeFiles/bench.dir/bench.cpp.o -MF bench/CMakeFiles/bench.dir/bench.cpp.o.d -o bench/CMakeFiles/bench.dir/bench.cpp.o -c /workspaces/vcpkg/buildtrees/spdlog/src/v1.10.0-3cbe543323/bench/bench.cpp
FAILED: bench/CMakeFiles/bench.dir/bench.cpp.o 
/usr/bin/c++ -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL -I/workspaces/vcpkg/buildtrees/spdlog/src/v1.10.0-3cbe543323/include -isystem /workspaces/vcpkg/installed/x64-linux/include -fPIC -g -std=c++11 -MD -MT bench/CMakeFiles/bench.dir/bench.cpp.o -MF bench/CMakeFiles/bench.dir/bench.cpp.o.d -o bench/CMakeFiles/bench.dir/bench.cpp.o -c /workspaces/vcpkg/buildtrees/spdlog/src/v1.10.0-3cbe543323/bench/bench.cpp
/workspaces/vcpkg/buildtrees/spdlog/src/v1.10.0-3cbe543323/bench/bench.cpp:18:14: fatal error: fmt/locale.h: No such file or directory
   18 | #    include <fmt/locale.h>
      |              ^~~~~~~~~~~~~~
compilation terminated.

The <fmt/locale.h> header has been marked as deprecated for a while
and has finally been removed in fmt v0.9.0:
fmtlib/fmt@5c7d315

Replace with <fmt/format.h> instead, as recommended.
@gabime gabime merged commit c5a09eb into gabime:v1.x Nov 12, 2022
@gabime
Copy link
Owner

gabime commented Nov 12, 2022

Thanks @kromain

@kromain kromain deleted the fix_bench_build branch November 14, 2022 15:17
BillyONeal added a commit to microsoft/vcpkg that referenced this pull request Nov 16, 2022
* [spdlog] Update to 1.11.0

* [spdlog] backporting gabime/spdlog#2545

* [spdlog] Add 1.11.0 to versions file

* Remove patch header, add link to upstream merged PR, add quotes.

Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants