Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Catch v3 support #2661

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Added Catch v3 support #2661

merged 2 commits into from
Mar 1, 2023

Conversation

xvitaly
Copy link
Contributor

@xvitaly xvitaly commented Mar 1, 2023

Added Catch v3 support. Second attempt.

@xvitaly
Copy link
Contributor Author

xvitaly commented Mar 1, 2023

Release configurations builds fine, but Debug fails.

@xvitaly
Copy link
Contributor Author

xvitaly commented Mar 1, 2023

It fails on this line: https://github.com/catchorg/Catch2/blob/devel/src/catch2/catch_test_case_info.cpp#L147

@gabime
Copy link
Owner

gabime commented Mar 1, 2023 •
edited

It seems that some tests has bad tags with extra closing ]]

see https://github.com/search?q=repo%3Agabime%2Fspdlog+%5D%5D%22&type=code

@xvitaly xvitaly mentioned this pull request Mar 1, 2023
Closed
@xvitaly
Copy link
Contributor Author

xvitaly commented Mar 1, 2023

It seems that some tests has bad tags with extra closing ]]

Yep. I will try to fix that.

@xvitaly
Copy link
Contributor Author

xvitaly commented Mar 1, 2023

@gabime It works now. Thanks for the pointer.

@xvitaly xvitaly marked this pull request as ready for review March 1, 2023 11:49
@xvitaly xvitaly changed the title [WIP] Added Catch v3 support Added Catch v3 support Mar 1, 2023
@gabime gabime merged commit 7f09c88 into gabime:v1.x Mar 1, 2023
@gabime
Copy link
Owner

gabime commented Mar 1, 2023

Thanks @xvitaly . Merged.

@gabime
Copy link
Owner

gabime commented Mar 1, 2023 •
edited

@xvitaly Unfortunately the windows appveyor CI fails now. Could you please take a look?

@xvitaly
Copy link
Contributor Author

xvitaly commented Mar 1, 2023

Unfortunately the windows appveyor CI fails now. Could you please take a look?

Typical Windows problem - missing Catch2Main.dll near spdlog-utests.exe.

@xvitaly
Copy link
Contributor Author

xvitaly commented Mar 1, 2023

We need to copy compiled Catch2Main.dll to spdlog-utests.exe if BUILD_SHARED is enabled.

@xvitaly
Copy link
Contributor Author

xvitaly commented Mar 1, 2023

I will try to fix that in a separate PR.

@gabime
Copy link
Owner

gabime commented Mar 1, 2023

Thanks

seker pushed a commit to seker/spdlog that referenced this pull request Mar 3, 2023
@xvitaly
Added Catch v3 support (gabime#2661)
8cfa588 
* Added Catch v3 support.

* Removed extra square brackets from some tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xvitaly @gabime