Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix os namespace in systemd_sink.h #2668

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

MyNameIsLame
Copy link
Contributor

#2619 added os::thread_id() function calls to spdlog/sinks/systemd_sink.h.

But access to os::thread_id() is not valid, as the full namespace is spdlog::details::os, while the current code is in the namespace spdlog::sinks and thus the namespace os:: is not directly accessible.

As a side note: The test_systemd.cpp is currently not built in the pipeline, because it fails to find systemd in the cmake configuration step. Mabye it is sufficient to install the libsystemd-dev package in the container?

@gabime
Copy link
Owner

gabime commented Mar 8, 2023

Thanks. I think details::os:: is enough and the spdlog:: can be omitted.
Regarding the fix to the CI, PR is welcome.

@MyNameIsLame
Copy link
Contributor Author

Removed the spdlog:: prefix and also created #2669

@gabime gabime merged commit 1262a24 into gabime:v1.x Mar 9, 2023
@gabime
Copy link
Owner

gabime commented Mar 9, 2023

Thanks @MyNameIsLame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants