Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ringbuffer_sink moving warning #2722

Merged
merged 1 commit into from
Apr 28, 2023
Merged

fix ringbuffer_sink moving warning #2722

merged 1 commit into from
Apr 28, 2023

Conversation

jamesruan
Copy link
Contributor

No description provided.

@jamesruan
Copy link
Contributor Author 

spdlog/include/spdlog/sinks/ringbuffer_sink.h:53:27: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
            ret.push_back(std::move(SPDLOG_BUF_TO_STRING(formatted)));
                          ^
spdlog/include/spdlog/sinks/ringbuffer_sink.h:53:27: note: remove std::move call here
            ret.push_back(std::move(SPDLOG_BUF_TO_STRING(formatted)));

@gabime gabime merged commit e4f92be into gabime:v1.x Apr 28, 2023
10 checks passed
@gabime
Copy link
Owner

gabime commented Apr 28, 2023

Thanks @jamesruan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamesruan @gabime