Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate completions and CI/CD #24

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Generate completions and CI/CD #24

merged 4 commits into from
Dec 4, 2023

Conversation

TD-Sky
Copy link
Contributor

@TD-Sky TD-Sky commented Dec 2, 2023

Changes

  • Generate completion scripts.
  • Create release assets when creating new tag.
  • Lint codes on pushing to main and pull requests.

References

Release assets: https://github.com/TD-Sky/Satty/releases/tag/v0.8.0
Actions: https://github.com/TD-Sky/Satty/actions

Notes

  1. You may not need Makefile anymore.
  2. PKGBUILD should be rewritten.
  3. I include the files which are suitable for publishing to crates.io even though satty isn't publish so far.

@TD-Sky
Copy link
Contributor Author

TD-Sky commented Dec 3, 2023

Test was over.

@gabm
Copy link
Owner

gabm commented Dec 4, 2023

wow thank you, what a great contribution 🎉

does this also install and package the icon the .desktop file?

@gabm gabm mentioned this pull request Dec 4, 2023
@TD-Sky
Copy link
Contributor Author

TD-Sky commented Dec 4, 2023

wow thank you, what a great contribution 🎉

does this also install and package the icon the .desktop file?

It doesn't actually do installation instead it packs the things what installation needs.

@gabm
Copy link
Owner

gabm commented Dec 4, 2023

okay cool.. that's what i meant... a tarball with all the sources and assets ..

@gabm gabm merged commit 891b4e9 into gabm:main Dec 4, 2023
@gabm
Copy link
Owner

gabm commented Dec 6, 2023

@TD-Sky there seems to be an error with the release pipeline?! https://github.com/gabm/Satty/actions/runs/7113283418/job/19364916436

@TD-Sky
Copy link
Contributor Author

TD-Sky commented Dec 6, 2023

Have you retried running action?

@gabm
Copy link
Owner

gabm commented Dec 6, 2023

I can do that but it says 403 .. so I guess a token is missing or something?

@gabm
Copy link
Owner

gabm commented Dec 6, 2023

I guess something from here? https://github.com/softprops/action-gh-release#permissions

@TD-Sky
Copy link
Contributor Author

TD-Sky commented Dec 6, 2023

Have you turned on CI/CD write permission in repo settings?

@gabm
Copy link
Owner

gabm commented Dec 6, 2023

no.. it seems that also can/needs to be requested as part of the workflow?

permissions:
  contents: write

@gabm
Copy link
Owner

gabm commented Dec 6, 2023

#32

@TD-Sky
Copy link
Contributor Author

TD-Sky commented Dec 6, 2023

I don't think so. I never write that when I met write permission problem and just turned on the setting.

@gabm
Copy link
Owner

gabm commented Dec 6, 2023

okay.. I think that turns it on for all jobs. I'd prefer having it in the workflow file

@gabm
Copy link
Owner

gabm commented Dec 6, 2023

works after #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants