Skip to content

Commit

Permalink
test: the returns from oracle is a string
Browse files Browse the repository at this point in the history
the library of `oracledb` returns ids with a string! discussion about this in knex#3134
  • Loading branch information
gabolera committed May 10, 2024
1 parent 73198ad commit 4dbc18e
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions test/integration2/query/insert/inserts.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ describe('Inserts', function () {
return v.toString() === '[object ReturningHelper:id]';
},
],
[{ id: 1 }]
[{ id: '1' }]
);
tester(
'mssql',
Expand Down Expand Up @@ -309,7 +309,7 @@ describe('Inserts', function () {
return v.toString() === '[object ReturningHelper:id]';
},
],
[{ id: 1 }, { id: 2 }]
[{ id: '1' }, { id: '2' }]
);
tester(
'mssql',
Expand Down Expand Up @@ -527,7 +527,7 @@ describe('Inserts', function () {
return v.toString() === '[object ReturningHelper:id]';
},
],
[{ id: 1 }, { id: 2 }]
[{ id: '1' }, { id: '2' }]
);
tester(
'mssql',
Expand Down Expand Up @@ -753,7 +753,7 @@ describe('Inserts', function () {
return v.toString() === '[object ReturningHelper:id]';
},
],
[[{ id: 1 }]]
[{ id: '1' }]
);
tester(
'mssql',
Expand Down Expand Up @@ -912,7 +912,7 @@ describe('Inserts', function () {
return v.toString() === '[object ReturningHelper:id]';
},
],
[{ id: 1 }]
[{ id: '1' }]
);
tester(
'mssql',
Expand Down Expand Up @@ -979,7 +979,7 @@ describe('Inserts', function () {
return v.toString() === '[object ReturningHelper:id]';
},
],
[{ id: 1 }]
[{ id: '1' }]
);
tester(
'mssql',
Expand Down

0 comments on commit 4dbc18e

Please sign in to comment.