Fix various issues #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Hammurabi only works in the current working directory * Read settings (pyproject.toml) path from ``HAMMURABI_SETTINGS_PATH`` environment variable * Fixed several CLI arguments related issues * Removed target directory setting from config and CLI
gabor-boros
added
bug
uvegla
reviewed
Mar 23, 2020
|
|
||
| repo_url: str = self.repo.remote().url | ||
|
|
||
| if re.match(r"^http(s)?://", repo_url): |
There was a problem hiding this comment.
I think a simple repo_url.startswith('http://') or repo_url.startswith('https://') is slightly more readable here.
There was a problem hiding this comment.
Hm, maybe yes. The only concern I have against the startswith is that it's longer, which could make the code less readable on the long run. WDYT?
There was a problem hiding this comment.
I am fine with the regex as well. 😃👍
uvegla
reviewed
Mar 23, 2020
uvegla
previously approved these changes
Mar 23, 2020
|
Code Climate has analyzed commit ad1b26d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (95% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.2% change). View more on Code Climate. |
uvegla
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change
We had various smaller issues across project. This PR will fix those issues and gives a bit better config handling.
Description
GitMixinclassHAMMURABI_SETTINGS_PATHenvironment variableCode examples
N/A
Checklist
- [ ] Stubs created/updatedReferences
N/A