tests: fix annoying flaky tests

gabor-boros · Oct 13, 2021 · 48b57c6 · 48b57c6
1 parent 8e05ab3
commit 48b57c6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/internal/pkg/client/clockify/clockify_test.go b/internal/pkg/client/clockify/clockify_test.go
@@ -204,7 +204,7 @@ func TestClockifyClient_FetchEntries(t *testing.T) {
 	})
 
 	require.Nil(t, err, "cannot fetch entries")
-	require.Equal(t, expectedEntries, entries, "fetched entries are not matching")
+	require.ElementsMatch(t, expectedEntries, entries, "fetched entries are not matching")
 }
 
 func TestClockifyClient_FetchEntries_TasksAsTags(t *testing.T) {
@@ -369,5 +369,5 @@ func TestClockifyClient_FetchEntries_TasksAsTags(t *testing.T) {
 	})
 
 	require.Nil(t, err, "cannot fetch entries")
-	require.Equal(t, expectedEntries, entries, "fetched entries are not matching")
+	require.ElementsMatch(t, expectedEntries, entries, "fetched entries are not matching")
 }
diff --git a/internal/pkg/client/tempo/tempo_test.go b/internal/pkg/client/tempo/tempo_test.go
@@ -253,7 +253,7 @@ func TestTempoClient_FetchEntries(t *testing.T) {
 	})
 
 	require.Nil(t, err, "cannot fetch entries")
-	require.Equal(t, expectedEntries, entries, "fetched entries are not matching")
+	require.ElementsMatch(t, expectedEntries, entries, "fetched entries are not matching")
 }
 
 func TestTempoClient_UploadEntries(t *testing.T) {

diff --git a/internal/pkg/client/timewarrior/timewarrior_test.go b/internal/pkg/client/timewarrior/timewarrior_test.go
@@ -133,7 +133,7 @@ func TestTimewarriorClient_FetchEntries(t *testing.T) {
 	})
 
 	require.Nil(t, err, "cannot fetch entries")
-	require.Equal(t, expectedEntries, entries, "fetched entries are not matching")
+	require.ElementsMatch(t, expectedEntries, entries, "fetched entries are not matching")
 }
 
 func TestTimewarriorClient_FetchEntries_TagsAsTasksRegex_NoSplit(t *testing.T) {
@@ -226,7 +226,7 @@ func TestTimewarriorClient_FetchEntries_TagsAsTasksRegex_NoSplit(t *testing.T) {
 	})
 
 	require.Nil(t, err, "cannot fetch entries")
-	require.Equal(t, expectedEntries, entries, "fetched entries are not matching")
+	require.ElementsMatch(t, expectedEntries, entries, "fetched entries are not matching")
 }
 
 func TestTimewarriorClient_FetchEntries_TagsAsTasks(t *testing.T) {
@@ -338,5 +338,5 @@ func TestTimewarriorClient_FetchEntries_TagsAsTasks(t *testing.T) {
 	})
 
 	require.Nil(t, err, "cannot fetch entries")
-	require.Equal(t, expectedEntries, entries, "fetched entries are not matching")
+	require.ElementsMatch(t, expectedEntries, entries, "fetched entries are not matching")
 }