Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename variable name to prevent collision with nginx 1.12 builtin var #1

Closed

Conversation

tykling
Copy link

@tykling tykling commented Apr 29, 2017

nginx 1.12 does not start with this module built in. This is because the variable name conflicts with the new builtin $request_id variable in nginx: nginx/nginx@f315b7a

@tykling
Copy link
Author

tykling commented Apr 29, 2017

@gabor
Copy link
Owner

gabor commented May 2, 2017

thanks for the pull-request, but i think a better approach is to simply not use this module anymore, and simply use the new $request_id builtin. i see that the freebsd-bug was handled this way too.

@gabor gabor closed this Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants