disable if else in gocritic lint

gabotechs · Jan 31, 2024 · 2236d69 · 2236d69
1 parent 91e9e70
commit 2236d69
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -11,6 +11,9 @@ linters-settings:
     check-all: true
   goimports:
     local-prefixes: dep-tree
+  gocritic:
+    disabled-checks:
+      - ifElseChain
   revive:
     confidence: 0.8
 

diff --git a/cmd/root.go b/cmd/root.go
@@ -151,13 +151,11 @@ func filesFromArgs(args []string) ([]string, error) {
 		abs, err := filepath.Abs(arg)
 		if err != nil {
 			errs = append(errs, err)
-			continue
-		}
-		if !utils.FileExists(abs) {
+		} else if !utils.FileExists(abs) {
 			errs = append(errs, fmt.Errorf("file %s does not exist", arg))
-			continue
+		} else {
+			result = append(result, abs)
 		}
-		result = append(result, abs)
 	}
 	if len(result) == 0 {
 		if len(errs) == 1 {

diff --git a/internal/js/workspaces.go b/internal/js/workspaces.go
@@ -99,7 +99,6 @@ func (w *Workspaces) ResolveFromWorkspaces(unresolved string) (string, error) {
 	var pkgJson *packageJson
 	for {
 		entry, ok := w.ws[firstSlice]
-		//nolint:gocritic
 		if ok {
 			pkgJson = entry
 			break