Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly parse the vint-width in matroska containers #185

Merged
merged 2 commits into from Sep 13, 2021
Merged

Correctly parse the vint-width in matroska containers #185

merged 2 commits into from Sep 13, 2021

Conversation

Kycklingar
Copy link
Contributor

Followup on #161 featuring a more robust fix to less than usual webm's.
Following the guide in https://mimesniff.spec.whatwg.org/#signature-for-webm as well as reading https://tools.ietf.org/id/draft-ietf-cellar-ebml-03.html#vintwidth

@Kycklingar Kycklingar mentioned this pull request Sep 9, 2021
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.429% when pulling 5f340cc on Kycklingar:whammy2 into a040a9f on gabriel-vasile:master.

gabriel-vasile
gabriel-vasile approved these changes Sep 13, 2021
View reviewed changes
Copy link
Owner

@gabriel-vasile gabriel-vasile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still work to be done to follow the mimesniff specification exactly, but it's a good step forward. Thank you!

@gabriel-vasile gabriel-vasile merged commit a9b9b9d into gabriel-vasile:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-vasile gabriel-vasile gabriel-vasile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kycklingar @coveralls @gabriel-vasile