Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13 Poster image URL to constant #25

Merged
merged 1 commit into from
Jul 3, 2023
Merged

13 Poster image URL to constant #25

merged 1 commit into from
Jul 3, 2023

Conversation

gabrielbmoro
Copy link
Owner

@gabrielbmoro gabrielbmoro commented Jul 3, 2023 •
edited
Loading

  • Removing constructor keyword, not necessary;
  • Moving the url prefix to be part of our mapper;
  • Adding a image place holder for empty imageUrls.

Closes #13

@gabrielbmoro
fix: Image urls handling improvements
fa2ee51 
- Removing constructor keyword, not necessary;
- Moving the url prefix to be part of our mapper;
- Adding a image place holder for empty imageUrls.
@gabrielbmoro gabrielbmoro self-assigned this Jul 3, 2023
@gabrielbmoro gabrielbmoro added bug Something isn't working enhancement New feature or request labels Jul 3, 2023
@gabrielbmoro gabrielbmoro merged commit 5c1d153 into main Jul 3, 2023
1 check passed
@gabrielbmoro gabrielbmoro deleted the feature/13-poster-image-url-to-constant branch July 3, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gabrielbmoro gabrielbmoro

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poster image URL to constant
1 participant
@gabrielbmoro