New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Linux theme too ! #47

Open
nsisodiya opened this Issue Nov 25, 2015 · 14 comments

Comments

Projects
None yet
@nsisodiya

nsisodiya commented Nov 25, 2015

I see, it has Mac and Window theme. I wish somebody should make a pull for Linux Gnome theme too !

@gabrielbull

This comment has been minimized.

Show comment
Hide comment
@gabrielbull
Owner

gabrielbull commented Nov 25, 2015

👍

3 similar comments
@junland

This comment has been minimized.

Show comment
Hide comment
@junland

junland commented Dec 19, 2015

+1

@michaelb87

This comment has been minimized.

Show comment
Hide comment
@michaelb87

michaelb87 commented Dec 24, 2015

+1

@yotamN

This comment has been minimized.

Show comment
Hide comment
@yotamN

yotamN commented Jan 10, 2016

+1

@olunx

This comment has been minimized.

Show comment
Hide comment
@olunx

olunx commented Jan 22, 2016

+1

@wietsedv

This comment has been minimized.

Show comment
Hide comment
@wietsedv

wietsedv Jan 22, 2016

The difficulty with this idea is that there is no real Gnome (Linux) look. The Mac OS X and Windows 10 styles in this project are hardcoded, which is not desirable when trying to make a Gnome theme. Being a Gnome 3 user myself, I would gladly commit to this project in the future by writing a modern GTK3 theme if Gabrielbull agrees. This theme will only support Linux DE's that support GTK3 themes. (This applies to most Linux users.)

The default look might be either the extremely ugly Ubuntu Ambiance theme (most Linux users use Ubuntu) or Adwaita, the default GTK theme for Gnome Shell users. For Electron applications it would be possible to see which GTK theme the user is using, and then look for the directory containing the CSS file and assets. Then I have to parse the CSS file and search for the needed styles so I can use these styles (and assets) for styling React Desktop.

But even if Gabriel agrees, I will probably wait until this project is a little more stable and documented.

wietsedv commented Jan 22, 2016

The difficulty with this idea is that there is no real Gnome (Linux) look. The Mac OS X and Windows 10 styles in this project are hardcoded, which is not desirable when trying to make a Gnome theme. Being a Gnome 3 user myself, I would gladly commit to this project in the future by writing a modern GTK3 theme if Gabrielbull agrees. This theme will only support Linux DE's that support GTK3 themes. (This applies to most Linux users.)

The default look might be either the extremely ugly Ubuntu Ambiance theme (most Linux users use Ubuntu) or Adwaita, the default GTK theme for Gnome Shell users. For Electron applications it would be possible to see which GTK theme the user is using, and then look for the directory containing the CSS file and assets. Then I have to parse the CSS file and search for the needed styles so I can use these styles (and assets) for styling React Desktop.

But even if Gabriel agrees, I will probably wait until this project is a little more stable and documented.

@gabrielbull

This comment has been minimized.

Show comment
Hide comment
@gabrielbull

gabrielbull Jan 26, 2016

Owner

Hi @wietsedv,

Thanks for chipping in.

But even if Gabriel agrees, I will probably wait until this project is a little more stable and documented.

Definitely wait until the project is at released, as I will be making some changes in the future that will break compatibility. I will keep you posted.

Cheers!

Owner

gabrielbull commented Jan 26, 2016

Hi @wietsedv,

Thanks for chipping in.

But even if Gabriel agrees, I will probably wait until this project is a little more stable and documented.

Definitely wait until the project is at released, as I will be making some changes in the future that will break compatibility. I will keep you posted.

Cheers!

@RoyTimes

This comment has been minimized.

Show comment
Hide comment
@RoyTimes

RoyTimes commented Jan 26, 2016

👍

@YurySolovyov

This comment has been minimized.

Show comment
Hide comment
@YurySolovyov

YurySolovyov Aug 26, 2016

Maybe it's possible to come up with theme that is generic enough that it looks ok on most popular DEs and provide some customization points so apps using it can tweak a bit to better match app style.
Thoughts?

YurySolovyov commented Aug 26, 2016

Maybe it's possible to come up with theme that is generic enough that it looks ok on most popular DEs and provide some customization points so apps using it can tweak a bit to better match app style.
Thoughts?

@csterritt

This comment has been minimized.

Show comment
Hide comment
@csterritt

csterritt Sep 10, 2016

@YurySolovyov I'd recommend against it -- Java tried this with Swing, and it was pretty much a disaster. Not that apps didn't look good, they just looked... weird... non-native. It was more of a PR disaster as a technical one.

On the other hand, Material Design has come out as a "platform-independent" design language, and it's doing pretty well, perhaps because it's Google behind it.

So maybe a MD theme?

csterritt commented Sep 10, 2016

@YurySolovyov I'd recommend against it -- Java tried this with Swing, and it was pretty much a disaster. Not that apps didn't look good, they just looked... weird... non-native. It was more of a PR disaster as a technical one.

On the other hand, Material Design has come out as a "platform-independent" design language, and it's doing pretty well, perhaps because it's Google behind it.

So maybe a MD theme?

@YurySolovyov

This comment has been minimized.

Show comment
Hide comment
@YurySolovyov

YurySolovyov Sep 10, 2016

@csterritt I like the idea, MD indeed fits into

theme that is generic enough that it looks ok on most popular DEs

YurySolovyov commented Sep 10, 2016

@csterritt I like the idea, MD indeed fits into

theme that is generic enough that it looks ok on most popular DEs

@minexew

This comment has been minimized.

Show comment
Hide comment
@minexew

minexew Dec 23, 2016

+1 react-desktop on macOS already feels non-native and uncanny, so it shouldn't be that big of an issue on Gnome

minexew commented Dec 23, 2016

+1 react-desktop on macOS already feels non-native and uncanny, so it shouldn't be that big of an issue on Gnome

@tofoli

This comment has been minimized.

Show comment
Hide comment
@tofoli

tofoli commented Jul 31, 2017

+1

@ArtGangsta

This comment has been minimized.

Show comment
Hide comment
@ArtGangsta

ArtGangsta Jul 2, 2018

The angst you have with regard "what looks like Linux" is self-imposed. If you Google search "Linux desktop" images, you'll get a lot of Ubuntu -- It's recognizable. That's what you make the theme look like. End of story.

Anyone wants something different -- it's an open source project. They can create their own.

ArtGangsta commented Jul 2, 2018

The angst you have with regard "what looks like Linux" is self-imposed. If you Google search "Linux desktop" images, you'll get a lot of Ubuntu -- It's recognizable. That's what you make the theme look like. End of story.

Anyone wants something different -- it's an open source project. They can create their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment