Added importTester #1
Conversation
| absKeys = list(additions['absolute'].keys())[:10] | ||
| relKeys = list(additions['relative'].keys())[:10] | ||
|
|
||
| absolute = "The following files should not contain relative imports\n" |
There was a problem hiding this comment.
Actually, I'm not certain, but I believe that it's not possible to use relative imports in test files. Meaning that there is quite some code which wouldn't be needed. Could you verify this? Thanks.
| absolute = "The following files should not contain relative imports\n" | ||
| for file in range(len(absKeys)): | ||
| absolute += absKeys[file] + "\n" | ||
| absolute += ("\nThis is " + str(file+1) + " out of " + len(additions['absolute']) + " files with relative imports to be changed\n") |
There was a problem hiding this comment.
prefer f-string formatting when possible. The docker image used is with python 3.7 so we're safe.
| @@ -0,0 +1,122 @@ | |||
| import os | |||
There was a problem hiding this comment.
python files should have names with uppercases. See PEP8.
|
|
||
| return errs | ||
|
|
||
| def checkImports(dirPath, style): |
There was a problem hiding this comment.
This function name does not follow PEP8. See https://www.python.org/dev/peps/pep-0008/
|
@gabrieldemarmiesse |
|
|
||
| os.system(cmd) | ||
|
|
||
| absoluteOnly = import_tester.check_imports("./" + repo_id + "/keras") |
There was a problem hiding this comment.
The current bot actually runs only keras-contrib. So I believe that this will fail as there is no ./keras directory in keras-contrib.
|
@JoshuaRM I'm going to be less and less active in the future on keras-team/keras, because I currently use tf.keras and I don't really want to maintain a package that I don't use. Going forward I believe that the best solution for you is to fork this repo, add your modification and make a bot account of your own. |
This PR contains additions to the
pull_request.pyas well as an additional scriptimportTester.py.This PR introduces the testing of relative and absolute imports in the keras and tests directories. The message sent to the user has been edited to now receive an additional parameter (additions) which is the import testing. The message adds the first 10 files with errors for both absolute and relative (20 total), and specifies how many remain eg. 10/56. This is done by cloning the users repo, parsing the files, then deleting the cloned repo.
Please let me know if you have any questions or concerns.