Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the test_cpus() testcase non-strict xfail for podman #597

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

LewisGaul
Copy link
Collaborator

It works on cgroups v2 or rootful:

$python -m pytest tests/python_on_whales/components/test_container.py -k cpus -v
============================================================== test session starts ==============================================================
platform linux -- Python 3.8.19, pytest-7.4.4, pluggy-1.5.0 -- /home/legaul/repos/python-on-whales/.venv/bin/python
cachedir: .pytest_cache
rootdir: /home/legaul/repos/python-on-whales
configfile: pyproject.toml
plugins: mock-3.14.0
collected 223 items / 221 deselected / 2 selected

tests/python_on_whales/components/test_container.py::test_cpus[docker] PASSED                                                             [ 50%]
tests/python_on_whales/components/test_container.py::test_cpus[podman] XPASS (Cgroup control not available with rootless podman on cg...) [100%]

================================================= 1 passed, 221 deselected, 1 xpassed in 2.31s ==================================================

Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That makes sense!

@gabrieldemarmiesse gabrieldemarmiesse merged commit 5683cd8 into gabrieldemarmiesse:master Jun 7, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants