Installable progressive web app #393
Open
+104
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added text mentioning the need to swipe on mobile devices. Signed-off-by: Shwetank Dixit <emailshwetank@gmail.com>
Signed-off-by: Shwetank Dixit <emailshwetank@gmail.com>
Signed-off-by: Shwetank Dixit <emailshwetank@gmail.com>
Signed-off-by: Shwetank Dixit <emailshwetank@gmail.com>
Signed-off-by: Shwetank Dixit <emailshwetank@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I know these are a lot of changes. Hopefully this can be accepted!
What I added:
Outcome
Now the game, if served over https, will be able to be added by browsers (right now its Opera for Android and Chrome) as an installable web app on the phone's homescreen, just like any other native app. Clicking on it will open the web app in full screen just like native. It will be capable of being opened offline, thanks to Service Worker support.
If I need to break the PR into smaller peices or if you have any other feedback, then please do let me know.
Thanks,