Skip to content

Commit

Permalink
Updated to support libraries v 23.2.0. It fixes the space in the recy…
Browse files Browse the repository at this point in the history
…cler view items due to the changes in the RecyclerView auto-measurement (check: http://goo.gl/JFPzGz).

Moved the target to v23.
  • Loading branch information
gabrielemariotti committed Mar 5, 2016
1 parent d1aa5c5 commit 83626cb
Show file tree
Hide file tree
Showing 12 changed files with 19 additions and 23 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Expand Up @@ -2,9 +2,9 @@ language: android
android:
components:
# The BuildTools version used by your project
- build-tools-22.0.1
- build-tools-23.0.1
# The SDK version used to compile your project
- android-22
- android-23
# Additional components
- extra-android-m2repository

Expand Down
8 changes: 4 additions & 4 deletions ChangeLogDemo/build.gradle
Expand Up @@ -10,7 +10,7 @@ android {

defaultConfig {
minSdkVersion 7
targetSdkVersion 22
targetSdkVersion 23
versionName project.VERSION_NAME
versionCode Integer.parseInt(project.VERSION_CODE)
}
Expand Down Expand Up @@ -42,9 +42,9 @@ dependencies {
// ChangeLog Library
compile project(':ChangeLogLibrary')
// Support Libraries
compile 'com.android.support:support-v4:22.2.0'
compile 'com.android.support:appcompat-v7:22.2.0'
compile 'com.android.support:design:22.2.0'
compile 'com.android.support:support-v4:23.2.0'
compile 'com.android.support:appcompat-v7:23.2.0'
compile 'com.android.support:design:23.2.0'
//To test layout
compile 'org.lucasr.dspec:dspec:0.1.1'
}
Expand Down
2 changes: 1 addition & 1 deletion ChangeLogDemo/src/main/AndroidManifest.xml
Expand Up @@ -7,7 +7,7 @@

<uses-sdk
android:minSdkVersion="7"
android:targetSdkVersion="22"
android:targetSdkVersion="23"
tools:overrideLibrary="org.lucasr.dspec"/>

<application
Expand Down
Expand Up @@ -20,7 +20,7 @@
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/chg_row"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_height="wrap_content"
android:layout_marginLeft="12dp"
android:orientation="vertical" >

Expand Down
Expand Up @@ -20,7 +20,7 @@
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/chg_row"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_height="wrap_content"
android:layout_marginLeft="12dp"
android:orientation="vertical" >

Expand Down
6 changes: 3 additions & 3 deletions ChangeLogLibrary/build.gradle
Expand Up @@ -10,7 +10,7 @@ android {

defaultConfig {
minSdkVersion 7
targetSdkVersion 22
targetSdkVersion 23
versionName project.VERSION_NAME
versionCode Integer.parseInt(project.VERSION_CODE)
}
Expand All @@ -22,8 +22,8 @@ android {
}

dependencies{
compile 'com.android.support:support-v4:22.2.0'
compile 'com.android.support:recyclerview-v7:22.2.0'
compile 'com.android.support:support-v4:23.2.0'
compile 'com.android.support:recyclerview-v7:23.2.0'
}

// Used to push in maven
Expand Down
2 changes: 0 additions & 2 deletions ChangeLogLibrary/src/main/AndroidManifest.xml
@@ -1,8 +1,6 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="it.gmariotti.changelibs">

<uses-sdk android:minSdkVersion="7" android:targetSdkVersion="22" />

<application/>

</manifest>
Expand Up @@ -2,7 +2,7 @@
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/chg_row"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_height="wrap_content"
android:layout_marginLeft="12dp"
android:orientation="vertical" >

Expand Down
Expand Up @@ -22,7 +22,7 @@
android:id="@+id/chg_row"
android:layout_width="match_parent"
android:minHeight="@dimen/chglib_material_minHeight"
android:layout_height="match_parent"
android:layout_height="wrap_content"
android:orientation="vertical" >

<LinearLayout
Expand Down
Expand Up @@ -2,7 +2,7 @@
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/chg_row"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_height="wrap_content"
android:layout_marginLeft="12dp"
android:orientation="vertical" >

Expand Down
Expand Up @@ -22,7 +22,7 @@
android:id="@+id/chg_row"
android:layout_width="match_parent"
android:minHeight="@dimen/chglib_material_minHeight"
android:layout_height="match_parent"
android:layout_height="wrap_content"
android:orientation="vertical" >

<LinearLayout
Expand Down
8 changes: 3 additions & 5 deletions build.gradle
Expand Up @@ -5,7 +5,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:1.2.3'
classpath 'com.android.tools.build:gradle:1.5.0'
}
}

Expand All @@ -15,8 +15,8 @@ def isReleaseBuild() {


ext {
compileSdkVersion = 22
buildToolsVersion = "22.0.1"
compileSdkVersion = 23
buildToolsVersion = "23.0.1"
}

allprojects {
Expand All @@ -27,5 +27,3 @@ allprojects {
mavenCentral()
}
}

apply plugin: 'android-reporting'

3 comments on commit 83626cb

@jrgonzalezg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!, i just experienced this issue when migrating an app to use version 23.2.1 of the support libraries. I am glad that it is fixed already and it would be great if you could generate a new version of the library in maven central with the fix included. Thanks! :)

@gabrielemariotti
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrgonzalezg Check the #28 . Currently there is a snapshot on maven. I will release soon the stable release.

@jrgonzalezg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!. Thanks :)

Please sign in to comment.