Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3k support, issue #15 #27

Closed
wants to merge 2 commits into from
Closed

py3k support, issue #15 #27

wants to merge 2 commits into from

Conversation

spulec
Copy link
Contributor

@spulec spulec commented Feb 14, 2013

Nothing particular interesting here. A few more uses of PY3 than I would like, but we can clean that up later.

@echo "Running functional tests ..."
@nosetests -s --verbosity=2 --with-coverage --cover-erase --cover-inclusive tests/functional --cover-package=httpretty

doctests: clean
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It deletes the .tox directory so the tests break. Maybe I'm doing something wrong.

@spulec spulec mentioned this pull request Feb 14, 2013
@@ -229,6 +256,7 @@ def sendall(self, data, *args, **kw):
hostnames = [i.hostname for i in HTTPretty._entries.keys()]
self.fd.seek(0)
try:
print("data", data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover from debugging?

@mlafeldt
Copy link

Different project, same problem: https://travis-ci.org/mlafeldt/rdd.py/builds/4816494

@mlafeldt mlafeldt mentioned this pull request Feb 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants