Mock time to make date-based tests reliable #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
======================================
Coverage 84.8% 84.8%
======================================
Files 6 6
Lines 849 849
Branches 129 129
======================================
Hits 720 720
Misses 87 87
Partials 42 42Continue to review full report at Codecov.
|
tests/functional/test_httplib2.py
Outdated
| @@ -64,10 +66,11 @@ def test_httpretty_provides_easy_access_to_querystrings(now): | |||
|
|
|||
|
|
|||
| @httprettified | |||
| @within(two=microseconds) | |||
| def test_httpretty_should_mock_headers_httplib2(now): | |||
| @patch('httpretty.core.datetime') | |||
There was a problem hiding this comment.
this would be better with freezegun
Use mocked clock when running tests involving checking the 'Date' header. These tests used system clock so far which caused frequent test failures if the check occurred in the second following generating the response. Fixes gabrielfalcao#376
|
Ping. |
|
great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use mocked clock when running tests involving checking the 'Date'
header. These tests used system clock so far which caused frequent
test failures if the check occurred in the second following generating
the response.
Fixes #376