Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expect.to.contain returns True always #104

Closed
codito opened this issue May 18, 2016 · 3 comments
Closed

expect.to.contain returns True always #104

codito opened this issue May 18, 2016 · 3 comments
Labels
bug fixed

Comments

@codito
Copy link
Contributor

codito commented May 18, 2016

Steps to repro:

>>> from sure import expect
>>> expect("hello").to.contain("world")
True

Looks like this may be overwriting actual and expected, so the comparison is always true.
@codito codito mentioned this issue May 18, 2016
Merged
@timofurrer
Copy link
Collaborator

Thanks for reporting this! I'll dig into that.

timofurrer added a commit to timofurrer/sure that referenced this issue Jun 5, 2016
@timofurrer
Fix bug which overwrote the obj property for the contain assertion. R…
45bcef9 
…efs gabrielfalcao#104
timofurrer added a commit that referenced this issue Jun 5, 2016
@timofurrer
Merge pull request #110 from timofurrer/issue/104
e6f2866 
Fix bug which overwrote the obj property for the contain assertion. Refs #104
@timofurrer timofurrer added fixed and removed verify labels Jun 5, 2016
@timofurrer
Copy link
Collaborator

I've fixed this.

Stay tuned for the next release! 🍻

@codito
Copy link
Contributor Author

codito commented Jun 6, 2016

thanks Timo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codito @timofurrer