refactor: fix Sonar findings (philips-software#337)

fix: cpp:S6232 well-defined type-punning method should be used instead of a union-based one
gabrielfrasantos · Jun 27, 2023 · d809c17 · d809c17
1 parent a294fb1
commit d809c17
Showing 1 changed file with 5 additions and 13 deletions.
diff --git a/services/network/NameResolverCache.cpp b/services/network/NameResolverCache.cpp
@@ -60,21 +60,13 @@ namespace services
 
     std::array<uint8_t, 16> NameResolverCache::Hash(infra::BoundedConstString name) const
     {
-        union
-        {
-            struct
-            {
-                std::array<uint8_t, 16> first;
-                std::array<uint8_t, 16> second;
-            } hash_parts;
-
-            std::array<uint8_t, 32> hash;
-        } result;
-
         Sha256MbedTls sha256;
-        result.hash = sha256.Calculate(infra::StringAsByteRange(name));
+        const auto hash = sha256.Calculate(infra::StringAsByteRange(name));
+
+        std::array<uint8_t, 16> result;
+        infra::Copy(infra::Head(infra::MakeRange(hash), result.size()), infra::MakeRange(result));
 
-        return result.hash_parts.first;
+        return result;
     }
 
     void NameResolverCache::TryResolveNext()