Small improvements #6
Conversation
|
Items spacing in collection view seems to be broken, I filed a bug on xamarin forms repo, we will see what they say about it. |
| CommandParameter="{Binding .}" | ||
| BackgroundColor="Red"/> | ||
| </SwipeItems> | ||
| </SwipeView.LeftItems> | ||
| <SwipeView.RightItems> | ||
| <SwipeItems Mode="Execute"> | ||
| <SwipeItem Text="View" | ||
| Command="{Binding Source={x:Reference HomePageView}, Path=BindingContext.ViewWidgetCommand}" | ||
| Command="{Binding Source={x:Reference WidgetCollection}, Path=BindingContext.ViewWidgetCommand}" |
There was a problem hiding this comment.
Does referencing the WidgetCollection and calling the Command really work or is it a typo ?
There was a problem hiding this comment.
This works, we are accessing the binding context of the collection view which is the binding context of the page
| /// Force layout for collectionview | ||
| /// </summary> | ||
| /// <returns></returns> | ||
| private async Task ForceCollectionLayout(int delay = 400) |
There was a problem hiding this comment.
Didn't you get display bugs while Adding/Removing widgets here ? I mean, the reason i'm doing this is related to the Issue you opened with Xamarin.Forms where the Spacing between the items breaks when you add/remove items, but i wonder if you managed to get around that issue even without forcing layout
There was a problem hiding this comment.
I changes it to not use spacing and instead sets small margin on each item for spacing. It's not ideal but it looks almost the same and you don't need to call layout and calculate height
| </CollectionView.ItemsLayout> | ||
| <CollectionView.ItemTemplate> | ||
| <DataTemplate> | ||
| <SwipeView BackgroundColor="Transparent"> | ||
| <ContentView> | ||
| <SwipeView Margin="5"> |
|
That was a lovely contribution, thank you very much @domagojmedo |
|
Just tested on my Device, the Margin really did the trick, great stuff, app feels much smoother on Android now. Will release a new version. Did you get improvements on your device ? |
|
It's smooth on my device, but some of the images are still really huge. You should make them smaller. Also check out https://github.com/Redth/ResizetizerNT/blob/master/README.md for easy way to create images for multiple resolutions at once. Haven't used it personally but that guy works on Xamarin so he probably knows what he's doing 🙂 There is also https://github.com/luberda-molinet/FFImageLoading/blob/master/README.md which further optimizes images on Android |
That's awesome. thanks for the links, haven't thought of optimizing the images, will have to do it indeed. |
Observable collections don't need backing fields
resized confirmed.png
you can directly reference view model properties from view