Use class_eval over reopening the class.

This way an exception is raised if the class doesn't exist, rather than silently/potentially erroneously defining it as a new class.
gabrielg · Jan 22, 2015 · fe4ec0d · fe4ec0d
1 parent 508c8ce
commit fe4ec0d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/text_helpers/railtie.rb b/lib/text_helpers/railtie.rb
@@ -4,7 +4,7 @@ class Railtie < Rails::Railtie
 
     initializer "text_helpers.configure_rails_initialization" do
 
-      class ActionView::Base
+      ActionView::Base.class_eval do
         include TextHelpers::Translation
 
         protected
@@ -28,7 +28,7 @@ def translation_scope
         end
       end
 
-      class ActionMailer::Base
+      ActionMailer::Base.class_eval do
         include TextHelpers::Translation
 
         protected
@@ -43,7 +43,7 @@ def translation_scope
         end
       end
 
-      class ActionController::Base
+      ActionController::Base.class_eval do
         include TextHelpers::Translation
 
         protected