Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervised PCA function - null density estimation for small number of pathways #8

Open
gabrielodom opened this issue Jun 5, 2018 · 2 comments
Assignees
Labels

Comments

@gabrielodom
Copy link
Owner

gabrielodom commented Jun 5, 2018

The estimation of the density of the null distribution (necessary for calculating the pathway $p$-values) depends on the number of pathways considered. While this is probably fine for 30+ pathways, the quality of this density estimate will be degraded for very small pathway sets (less than 15?).

We should add in a new function that permutes the response for each pathway, and treats that permuted pathway as a new pathway, to "fill out" the number of pathways. I don't know how many times we should do this, but I guess 100 at least.

@gabrielodom gabrielodom added the bug label Jun 5, 2018
@gabrielodom gabrielodom added this to the Bioconductor Submission milestone Jun 5, 2018
@gabrielodom gabrielodom self-assigned this Jun 5, 2018
@gabrielodom
Copy link
Owner Author

Create 5 copies of each pathway, with a parametric bootstrap response, to help creating the null distribution. How do we properly adjust for FDR when we would have 15-20 original pathways, but now 5 x 20 more noise pathways? We should only adjust the original $p$-values, and ignore the $p$-values from these new null (parametric bootstrap) pathways.

@gabrielodom
Copy link
Owner Author

gabrielodom commented Aug 20, 2018

Until we fix this, add a warning to the superPCA_pVals() function to the user to avoid using pathway collections with fewer than 30 pathways.

@lxw391 lxw391 changed the title Supervised PCA null density estimation issue Supervised PCA function - null density estimation for small number of pathways Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant