Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of Dart Extension Method. #8

Merged
merged 4 commits into from
Jan 2, 2020

Conversation

abayomiAkanji
Copy link

@abayomiAkanji abayomiAkanji commented Dec 21, 2019

Hi Gabriel,

Many thanks for this implementation. The translator works very seamlessly and I enjoy using it.

With the release of Dart extension methods, I thought that calling the translate method directly on the String as a static method might be another interesting way of referencing it.

What do you think?

It looks like this (without changing the current way it works):

final input = "Здравствуйте. Ты в порядке?";
final translation = await input.translate(to: 'en');

N.B: Consequently, the Dart minimum version is increased to 2.6.0 (because of the Extension Methods Feature)

@abayomiAkanji abayomiAkanji changed the title Integration of Dart Extension method. Integration of Dart Extension Method. Dec 21, 2019
@gabrielpacheco23 gabrielpacheco23 merged commit 823ab61 into gabrielpacheco23:master Jan 2, 2020
@gabrielpacheco23
Copy link
Owner

gabrielpacheco23 commented Jan 2, 2020

Thank you for your contribution! I merged your pull request, as well as upgraded this package version to "0.1.4".

@abayomiAkanji
Copy link
Author

This is good to know, @gabrielpacheco23

Well done.

@faysalneowaz faysalneowaz mentioned this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants