Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont-exit-on-errors #97

Merged
merged 1 commit into from
Mar 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/AwsHelpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def assume_role(logger, aws_account_number, role_name, duration=assume_role_dura
)
except (ClientError, NoCredentialsError) as e:
logger.error("Error assuming IAM role: {}".format(e))
exit(1)
return False
# Session
logger.info(
"Getting session for assumed IAM Role: %s (%s)", role_name, aws_account_number
Expand All @@ -49,7 +49,7 @@ def assume_role(logger, aws_account_number, role_name, duration=assume_role_dura
)
except ClientError as e:
logger.error("Error getting session for assumed IAM role: {}".format(e))
exit(1)
return False
return boto3_session


Expand All @@ -74,14 +74,14 @@ def get_region(logger):


def get_available_regions(logger, aws_service):
available_regions = []
try:
my_session = boto3.session.Session()
available_regions = my_session.get_available_regions(aws_service)
except (NoCredentialsError, ClientError) as e:
logger.error(
"Error getting available regions for Service {}: {}".format(aws_service, e)
)
exit(1)
return available_regions


Expand Down Expand Up @@ -125,7 +125,7 @@ def get_boto3_client(logger, service, region, sess=None, profile=None):
e
)
)
exit(1)
return False
return boto3.client(service_name=service, region_name=region)
except Exception as e:
logger.error("Error getting boto3 client: {}".format(e))