Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocate rockstar popup #16

Closed

Conversation

JasonBuckner
Copy link

Moves the main rockstar popup to the bottom left corner of the browser window.
Addresses Issue #12 .
Other popups, such as 'API Explorer', still display in the upper left corner.

Moves the main rockstar popup to the bottom left corner of the browser window. Other popups, such as 'API Explorer', still display in the upper left corner.
@JasonBuckner JasonBuckner marked this pull request as ready for review May 4, 2021 16:46
@gabrielsroka
Copy link
Owner

Hi @JasonBuckner
did you test that change? the css you modified is commented out.

instead, see
https://github.com/gabrielsroka/gabrielsroka.github.io/blob/master/rockstar/rockstar.js#L1188-L1193

@gabrielsroka
Copy link
Owner

also, have you tried using the minimize button _ ?

@JasonBuckner
Copy link
Author

Commented out? Well, that's embarrassing. Silly me.

@JasonBuckner
Copy link
Author

The minimize button doesn't move the rockstar popup sufficiently to navigate to the hamburger menu on some resolutions. Simply put, it still doesn't move rockstar out of the way.
I'll submit another PR.

@gabrielsroka
Copy link
Owner

gabrielsroka commented May 4, 2021

this might help https://github.com/gabrielsroka/gabrielsroka.github.io/blob/master/rockstar/readme.md

some resolutions

can you send a screen shot or provide more detail?

@JasonBuckner
Copy link
Author

I use a vertical monitor configuration (1200x1920). The screenshots at #12 are helpful, but I find the default rockstar popup location (upper left corner) to be the most egregious when my browser is less than about 1303px in width. That's when the "hamburger" menu appears as seen at #12 (comment).

@gabrielsroka
Copy link
Owner

makes sense. i don't have a good solution right now. you can disable rockstar and re-enable it just when u need. or close it when u need the hamburger menu (which is all the time -- that must be annoying). or use a different monitor. or modify rockstar (or its style) to better suit your use case. i designed it before the hamburger menu, and for landscape mode.

@JasonBuckner
Copy link
Author

Moving the popup to the bottom of the browser seems a perfectly cromulent solution.
Perhaps you could get fancy and only move it when the detected window width is less than 1350 px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants