Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update - 7/16/2023 #230

Closed
wants to merge 0 commits into from
Closed

Update - 7/16/2023 #230

wants to merge 0 commits into from

Conversation

Bashamega
Copy link
Contributor

#92
Hello:)
I have changed the json file, to be a db on firebase RealTime db.
I have made it that users can add their exercises to the website easily, using the AddExercisePage.

@netlify
Copy link

netlify bot commented Jul 16, 2023

Deploy Preview for gym-junkies ready!

Name Link
🔨 Latest commit 8b34045
🔍 Latest deploy log https://app.netlify.com/sites/gym-junkies/deploys/64bb508ac9a30800088c359d
😎 Deploy Preview https://deploy-preview-230--gym-junkies.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 16, 2023

Deploy Preview for gymjunkies ready!

Name Link
🔨 Latest commit 8b34045
🔍 Latest deploy log https://app.netlify.com/sites/gymjunkies/deploys/64bb508aeda4b800071e9dcb
😎 Deploy Preview https://deploy-preview-230--gymjunkies.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Bashamega
Copy link
Contributor Author

@gabrysia694

@gabrysia694
Copy link
Owner

#92 Hello:) I have changed the json file, to be a db on firebase RealTime db. I have made it that users can add their exercises to the website easily, using the AddExercisePage.

Hello :)
Overall looks great but I've got just a few suggestions. There's a small typo, instead of Excersize should be Exercise. Could you add some margin on Add Exercise page so it's not glued to the edges of a mobile screen? The author doesn't show up when the exercise is added, I believe it's the setauth instead of setAuthor. I'm also a bit afraid of bots, maybe we could add CAPTCHA to verify users?

@Bashamega
Copy link
Contributor Author

#92 Hello:) I have changed the json file, to be a db on firebase RealTime db. I have made it that users can add their exercises to the website easily, using the AddExercisePage.

Hello :) Overall looks great but I've got just a few suggestions. There's a small typo, instead of Excersize should be Exercise. Could you add some margin on Add Exercise page so it's not glued to the edges of a mobile screen? The author doesn't show up when the exercise is added, I believe it's the setauth instead of setAuthor. I'm also a bit afraid of bots, maybe we could add CAPTCHA to verify users?

Hello:)
Sorry for the typos I will fix them, and add the recaptcha

@Bashamega Bashamega closed this Jul 22, 2023
@Bashamega Bashamega force-pushed the main branch 2 times, most recently from 42c4aae to 8b34045 Compare July 22, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants