fix attributes arguments in relation computed attributes to be optional

gabynaiman · Oct 28, 2020 · e36e67e · e36e67e
1 parent aed01e3
commit e36e67e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/rasti/db/computed_attributes/relation.rb b/lib/rasti/db/computed_attributes/relation.rb
@@ -3,11 +3,11 @@ module DB
     module ComputedAttributes
       class Relation
 
-        def initialize(value:, table:, type:, attributes:, foreign_key:)
+        def initialize(value:, table:, type:, foreign_key:, attributes: [])
           @value = value
           @table = table
           @type = type
-          @attributes = attributes
+          @attributes = attributes.push foreign_key
           @foreign_key = foreign_key
         end
 

diff --git a/spec/minitest_helper.rb b/spec/minitest_helper.rb
@@ -30,7 +30,6 @@ class Users < Rasti::DB::Collection
     Rasti::DB::ComputedAttributes::Relation.new value: Sequel.function('count', :id),
                                                 table: db[:comments],
                                                 type: :inner,
-                                                attributes: [:user_id],
                                                 foreign_key: :user_id
   end