Computed fields #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d when has an computed attribute
gabynaiman
reviewed
Nov 3, 2020
lib/rasti/db/nql/syntax.treetop
Outdated
| rule field | ||
| _tables:(table:field_name '.')* _column:field_name <Nodes::Field> | ||
| rule computed_attribute | ||
| name:basic '()' <Nodes::ComputedAttribute> |
There was a problem hiding this comment.
No debería ir attribute_name en lugar de basic?
Rename method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
computed fieldsin nql syntax and collection syntax. Is an option to can have custom method for resolution in nql. Use the same gramatic to comapre like a simple attribute.Unify the term
FieldasAttribute, have no inconsistencies or ambiguities.Computed attributes are saved in a hash on collection, and use a object like a wrapper to save it, called
ComputedAttribute.Add a method in
queryto can append that computed field, this method realice the join if is necesary,