Refactor AbstractFactory

gacela-project · Oct 14, 2023 · e2d5011 · e2d5011
1 parent 2e45a15
commit e2d5011
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/composer.json b/composer.json
@@ -32,7 +32,7 @@
         "gacela-project/container": "^0.5"
     },
     "require-dev": {
-        "friendsofphp/php-cs-fixer": "^3.34",
+        "friendsofphp/php-cs-fixer": "^3.35",
         "infection/infection": "^0.26",
         "phpbench/phpbench": "^1.2",
         "phpmetrics/phpmetrics": "^2.8",

diff --git a/composer.lock b/composer.lock
diff --git a/src/Framework/AbstractConfig.php b/src/Framework/AbstractConfig.php
@@ -18,6 +18,8 @@ public function getAppRootDir(): string
     }
 
     /**
+     * Get a project config value by its key.
+     *
      * @throws ConfigException
      */
     protected function get(string $key, mixed $default = Config::DEFAULT_CONFIG_VALUE): mixed

diff --git a/src/Framework/AbstractFactory.php b/src/Framework/AbstractFactory.php
@@ -43,17 +43,9 @@ private function createContainerWithProvidedDependencies(): Container
     {
         $container = Container::withConfig(Config::getInstance());
 
-        $dependencyProvider = $this->resolveDependencyProvider();
+        $dependencyProvider = (new DependencyProviderResolver())->resolve($this);
         $dependencyProvider->provideModuleDependencies($container);
 
         return $container;
     }
-
-    /**
-     * @throws ClassResolver\DependencyProvider\DependencyProviderNotFoundException
-     */
-    private function resolveDependencyProvider(): AbstractDependencyProvider
-    {
-        return (new DependencyProviderResolver())->resolve($this);
-    }
 }