Add container factory method #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chemaclass
requested review from
localheinz,
webcraftniray,
JesusValera and
antonio-gg-dev
JesusValera
reviewed
Nov 12, 2022
| { | ||
| $this->container->set( | ||
| 'service_name', | ||
| $this->container->factory( |
There was a problem hiding this comment.
I am not completely convinced of the factory name.
Probably, I would rename the methods to:
instance(for thefactorymethod)singleton(for thegetmethod)
What do you think? 馃
Similar to how Laravel does.
There was a problem hiding this comment.
Good observation, but actually this is the same naming Spryker is using in their internal Container as well. I kinda like it, and I would prefer to have a similar name in this area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摎 Description
Currently, the
Containercaches in memory the result of the service afterContainer::get('service-key')is called. This is useful forFacadesbut it might not be the best when creating other types of dependencies.With this new feature, you can define in your
DependencyProviderto resolve a particular service every time, avoiding caching it in memory. This is useful when you want to force the creation of a dependency instead of sharing it as singleton.馃敄 Changes
Container::factory()to avoid caching the result of the service when callingContainer::get('service-key').