-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"one step ahead" predictions to assess the fit to data #63
Comments
This is nonsense. Then it doesn't match the observations array, which is the whole point. |
The main decision left here is how it's off-on'ed. We can just add it everywhere but doing so creates a useless array of 1's. However, adding explicit "indicator_var" booleans to |
Modify distribution functions to include a keep, which gets plumbed in as a DATA_ARRAY_INDICATOR into our model. This should in theory work, however:- * We need to be able to off/on the keep support, otherwise it clogs up models with unnecessary arrays of 1. * TMB::oneStepPredict seemingly has no concept of array stride, without I'm not sure how we might off/on e.g. all length observations for a single timestep. Without we're not convinced this is very useful.
An attempt at doing this is in the commit above. Parking this for now until we've worked out how to turn on/off for an entire timestep in one go |
Support the use of TMB::oneStepPredict() in gadget3-generated models. This
will require the addition of an “indicator variable”, with the same dimensions as the
observations array, used to turn individual observations on/off when calculating
likelihood. Add examples to the demo-ling model to show how it could be used.
The text was updated successfully, but these errors were encountered: