Rework action_age so age re-ordering is possible #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
substitute "default" / "missing" into subset expressions, so you can specify "default + 1" as well as "default". Add "vec" parameter so you can subset all dimensions up to a given one, as well as all/nothing.
stock_ss() now has enough flexibility to replace action_age's custom shenanigans, so rewrite with stock_ss() Use "vec = age", rather than "vec = all", so we no longer have to have age dimensions at the start.
Without an age dimension, the stock_ss() calls will fail, but it's not a sensible thing to do in the first place. Fail with an informative error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra options to
stock_ss()so we can ditchaction_age()s custom logic, allowing the age/area dimension to be reordered.