Process groups #82
Merged
Process groups #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasong689
approved these changes
Jun 9, 2023
…one child process This fixes a bug where when wds is orchestrating a process that starts its own child processes, those child processes can be come zombies if we just SIGTERM/SIGKILL the main orchestrated process. What we need to do is kill the whole process group, which you can do by sending the negative pid of the parent to the kernel. See https://azimi.me/2014/12/31/kill-child_process-node-js.html
|
I did unfortunately run into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed an issue where wds can leave around zombie processes when reloading if the process running under wds creates its own subprocesses. This happens in gadget when we use wds to run the
apiprocess, which then runs its own sandbox subprocesses. When wds SIGTERMs or SIGKILLs the api process, the signals don't get sent down to the child process. I am not exactly sure why this is in POSIX land, but the internet has some good evidence this is the case.When wds wants to kill the orchestrated process, we can ensure child processes are terminated too by killing the whole process group. See https://azimi.me/2014/12/31/kill-child_process-node-js.html for details