Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not build apps/gadgetron/test if BUILD_TESTING=OFF #1176

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

KrisThielemans
Copy link
Contributor

Fixes #1174

@paskino, I hope you're not doing the same thing :-)

@hansenms
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KrisThielemans
Copy link
Contributor Author

I suppose it'd be best if CI would test a config with BUILD_TESTING=OFF to prevent this from happening again, but I'll leave that to others...

@hansenms
Copy link
Member

@KrisThielemans I'm not sure building without testing is something we should do. I don't mind having it here since you need it, but I really wouldn't recommend not building the tests.

@hansenms
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hansenms hansenms merged commit 76c3daf into gadgetron:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting BUILD_TESTING=OFF leads to errors during build
2 participants