Cached file is empty using NodeFs store.

[nocodehummel]

The cached file is empty using NodeFs store. The filename is incomplete with myurll[headers.

The below function does not render a valid filename.

async idFromResponse(request: Request): Promise<string> {
  let filename = filenamifyUrl(request.url);
  if (Array.from(request.headers.keys()).length > 0) {
    const headersHash = await this.hashFromHeaders(request.headers, 7);
    filename += `[headers:${headersHash}]`;
  }
  return filename + ".json";
}

A solution would be to only render the filename with filenamifyUrl and let the calling code add query string to make cached files unique for specific test cases. That approach would also allow for meaningful filenames.

[nocodehummel]

A minor code change fixes the problem with the filename.

filename += `[headers:${headersHash}]`;

filename += `[headers=${headersHash}]`;

[gadicc]

Great find & fix, thanks, I may have made some assumptions about being on Linux 😅

[github-actions]

🎉 This issue has been resolved in version 1.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀