-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to make this package work with Flow Router SSR? #17
Comments
I admit this was something I didn't originally consider (needing different babel config for the server/client), but it was recently pointed out to me by jedwards here. You can see the discussion in there, or, in short, this will be addressed in the next release or two. |
@sammkj can you try |
thank you @gadicc for fixing this! However I don't think this is working with FlowRouter SSR. FR requires a shared folder to make SSR work. It seems like the new update is looking for |
Ah, damn :( No, we look for any client compilation now, however, the server restart (from a change in server/both code) kills react-hotloader before it can get the update across. I'll have to think about this some more. Thanks for the update. |
I think this should be working now, can you check when you have a chance? Since |
😱 I just tested the newest version. It's working perfectly! However it's not nearly as fast as reloading components in |
Great stuff! (for the first part) Thanks for reporting back. I'm going to close this issue and track the speed part in #26. |
I keep getting this error when I do
meteor
with FlowRouter SSR:I had to do
meteor --production
or explicitly setBABEL_ENV=production meteor
to make the error go away. The problem is if I do this, I don't get instant react update. Any pointers to fix this would be greatly appreciated!The text was updated successfully, but these errors were encountered: