Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider passing custom options.Module to makeInstaller? #3

Closed
benjamn opened this issue Feb 10, 2016 · 1 comment
Closed

Consider passing custom options.Module to makeInstaller? #3

benjamn opened this issue Feb 10, 2016 · 1 comment

Comments

@benjamn
Copy link

benjamn commented Feb 10, 2016

If you want to make module.hot available to all modules, you can provide your own Module constructor as an option when you call makeInstaller.

If that doesn't make any sense, or doesn't work, let me know and I can provide more details.

@gadicc
Copy link
Owner

gadicc commented Feb 12, 2016

Hey, @benjamn, great seeing you here :)

The original aim for this project was a lot more modest - just react hot loading (using a partial and fake HMR implementation). But in light of your comments on the forum, I'm going to aspire for full HMR support, as per webpack's API, so that this can work with any module (e.g. redux's built-in hmr support).

I've made a start here and it indeed looks a lot cleaner. The full API is a lot more involved though and my time is a bit limited atm. I'll keep you posted.

Also FYI, relating to a previous issue you bought up, here's what hot loading looks like with native ES6 imports in webpack2: webpack/webpack#1885.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants