Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHLv3 and Mantra style apps #60

Closed
gadicc opened this issue Apr 29, 2016 · 8 comments
Closed

RHLv3 and Mantra style apps #60

gadicc opened this issue Apr 29, 2016 · 8 comments
Milestone

Comments

@gadicc
Copy link
Owner

gadicc commented Apr 29, 2016

Currently react-hot-loader/patch is breaking Mantra. Need to investigate further. For now, you can still use the HMR without react-hot-loader: hot reloading will work but state stored inside components will be lost on updates.

See https://github.com/gadicc/mantra-sample-blog-app-hot.

@Vincent-P
Copy link

So this part of the README needs to be updated :

  1. Works great with
    mantra-sample-blog-app
    (but you need to remove babel-root-slash-import, which might break some
    of your testing, tracking in
    #82).

@gadicc
Copy link
Owner Author

gadicc commented Apr 29, 2016

Ooh wow, yes, on that!

gadicc added a commit that referenced this issue Apr 29, 2016
@Vincent-P
Copy link

I don't know how it is supposed to work with currently only the main layout hot reloads.

@gadicc
Copy link
Owner Author

gadicc commented Apr 29, 2016

Oops, you're right... PostList, Post and NewPost aren't reloaded, I need to add in some logic for this. Sorry, I rushed to try get something up before I went away, so I missed this, and don't have any more time now :( I'm back on Tuesday if you or anyone else doesn't manage to figure something out by then, I'd still like to try find a better pattern.

@gadicc
Copy link
Owner Author

gadicc commented May 3, 2016

I'm back and have updated the repo there, everything works now, including component-level state (thanks for the latest RHL beta).

@gadicc gadicc added the question label May 4, 2016
@gadicc
Copy link
Owner Author

gadicc commented May 5, 2016

Thanks again for all the help last week! I'm closing this, because I'm pretty sure it's solved. But please re-open if any issues or comments.

@gadicc gadicc closed this as completed May 5, 2016
@tomitrescak
Copy link

Is the mantra example repo maintained? Thanks for all the amazing work!

@gadicc
Copy link
Owner Author

gadicc commented May 5, 2016

thanks @tomitrescak! which one? the original or the -hot one? I think the original is maintained but I think still on an 1.3-rc iirc. the -hot one is from a few days ago, so it's up to date now, not sure what the future will look like :D but the main idea there is just to show the pattern / changeset from original mantra.

@gadicc gadicc added this to the v2 milestone May 7, 2016
@gadicc gadicc added the docs label May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants