fix(setGlobalConfig): add to index; minor improvements (#376)

gadicc · Jan 15, 2022 · 464f26f · 464f26f
1 parent f94724a
commit 464f26f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/schema.json b/schema.json
@@ -36,10 +36,6 @@
           "type": "boolean"
         }
       },
-      "required": [
-        "logErrors",
-        "logOptionsErrors"
-      ],
       "additionalProperties": false
     },
     "AutocResultSet": {

diff --git a/src/index-common.ts b/src/index-common.ts
@@ -3,6 +3,7 @@ import yahooFinanceFetch from "./lib/yahooFinanceFetch.js";
 import moduleExec from "./lib/moduleExec.js";
 import options from "./lib/options.js";
 import errors from "./lib/errors.js";
+import setGlobalConfig from "./lib/setGlobalConfig.js";
 
 // modules
 import autoc from "./modules/autoc.js";
@@ -26,8 +27,9 @@ export default {
   _moduleExec: moduleExec,
   _opts: options,
 
-  // errors
+  // common
   errors,
+  setGlobalConfig,
 
   // modules,
   autoc,

diff --git a/src/lib/validateAndCoerceTypes.ts b/src/lib/validateAndCoerceTypes.ts
@@ -191,8 +191,8 @@ export function resolvePath(obj: any, instancePath: string) {
 }
 
 export interface ValidationOptions {
-  logErrors: boolean;
-  logOptionsErrors: boolean;
+  logErrors?: boolean;
+  logOptionsErrors?: boolean;
 }
 
 export interface ValidateParams {
@@ -227,7 +227,7 @@ function validate({
           error.data = resolvePath(object, error.instancePath);
       });
 
-    if (options.logErrors) {
+    if (options.logErrors === true) {
       const title = encodeURIComponent("Failed validation: " + schemaKey);
       console.log(
         "The following result did not validate with schema: " + schemaKey
@@ -258,7 +258,7 @@ see https://github.com/gadicc/node-yahoo-finance2/tree/devel/docs/validation.md.
       errors: validator.errors,
     });
   } /* if (type === 'options') */ else {
-    if (options.logOptionsErrors) {
+    if (options.logOptionsErrors === true) {
       console.error(
         `[yahooFinance.${source}] Invalid options ("${schemaKey}")`
       );