Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed validation: #/definitions/QuoteSummaryResult #295

Closed
favasconcelos opened this issue Sep 24, 2021 · 2 comments
Closed

Failed validation: #/definitions/QuoteSummaryResult #295

favasconcelos opened this issue Sep 24, 2021 · 2 comments
Labels
bug Something isn't working released validation Issues related to validation

Comments

@favasconcelos
Copy link

favasconcelos commented Sep 24, 2021

Validation Error

Minimal Reproduction

await yahooFinance.quoteSummary('CRM', { modules: ['assetProfile'] });

Symbol(s) that it happened for

  • CRM

Error Message

 The following result did not validate with schema: #/definitions/QuoteSummaryResult
 [
   {
     "instancePath": "/assetProfile",
     "schemaPath": "#/additionalProperties",
     "keyword": "additionalProperties",
     "params": {
       "additionalProperty": "industrySymbol"
     },
     "message": "must NOT have additional properties",
     "data": {
       "address1": "Salesforce Tower",
       "address2": "3rd Floor 415 Mission Street",
       "city": "San Francisco",
       "state": "CA",
       "zip": "94105",
       "country": "United States",
       "phone": "415 901 7000",
       "fax": "415 901 7040",
       "website": "http://www.salesforce.com",
       "industry": "Software—Application",
       "industrySymbol": "h885",
       "sector": "Technology",
       "longBusinessSummary": "salesforce.com, inc. develops enterprise cloud computing solutions with a focus on customer relationship management worldwide. The company offers Sales Cloud to store data, monitor leads and progress, forecast opportunities, and gain insights through analytics and relationship intelligence, as well as deliver quotes, contracts, and invoices. It also provides Service Cloud, which enables companies to deliver personalized customer service and support, as well as a field service solution that enables companies to connect agents, dispatchers, and mobile employees through a centralized platform, which helps to schedule and dispatch work, and track and manage jobs in real-time. In addition, the company offers Marketing Cloud to plan, personalize, and optimize one-to-one customer marketing interactions; and Commerce Cloud, which enables companies to enhance engagement, conversion, revenue, and loyalty from their customers. Further, it provides Customer 360 Platform that offers no-code to pro-code Platform-as-a-Service tools for building, securing, integrating, and managing the business apps; MuleSoft Anypoint Platform enables customers to connect any system, application, data, or device; Quip collaboration platform, which combines documents, spreadsheets, apps, and chat with live CRM data; and Tableau and Einstein Analytics, provides analytical technology to customers. Additionally, the company offers various solutions for financial services, healthcare and life sciences, manufacturing, consumer goods, government, and philanthropy. The company also provides professional services and education services, including instructor-led and online courses; and support and adoption programs. It provides its services through direct sales; and consulting firms, systems integrators, and other partners. salesforce.com, inc. has a strategic partnership with Siemens and Amazon Web Services, Inc. The company was founded in 1999 and is headquartered in San Francisco, California.",
       "fullTimeEmployees": 65595,
       "companyOfficers": [
         {
           "maxAge": 1,
           "name": "Mr. Marc R. Benioff",
           "age": 55,
           "title": "Co-Founder, Chairman & CEO",
           "yearBorn": 1965,
           "fiscalYear": 2021,
           "totalPay": 5740655,
           "exercisedValue": 218569824,
           "unexercisedValue": 448961632
         },
         {
           "maxAge": 1,
           "name": "Mr. Bret Steven Taylor",
           "age": 40,
           "title": "Pres & COO",
           "yearBorn": 1980,
           "fiscalYear": 2021,
           "totalPay": 1919068,
           "exercisedValue": 0,
           "unexercisedValue": 17011440
         },
         {
           "maxAge": 1,
           "name": "Mr. Srinivas  Tallapragada",
           "age": 50,
           "title": "Pres & Chief Engineering Officer",
           "yearBorn": 1970,
           "fiscalYear": 2021,
           "totalPay": 2070617,
           "exercisedValue": 10520356,
           "unexercisedValue": 41148576
         },
         {
           "maxAge": 1,
           "name": "Mr. Gavin E. Patterson",
           "age": 52,
           "title": "Pres & Chief Revenue Officer",
           "yearBorn": 1968,
           "fiscalYear": 2021,
           "totalPay": 3078317,
           "exercisedValue": 0,
           "unexercisedValue": 1044204
         },
         {
           "maxAge": 1,
           "name": "Mr. Parker  Harris",
           "age": 53,
           "title": "Co-Founder, CTO & Director",
           "yearBorn": 1967,
           "fiscalYear": 2021,
           "totalPay": 0,
           "exercisedValue": 0,
           "unexercisedValue": 0
         },
         {
           "maxAge": 1,
           "name": "Ms. Robin L. Washington",
           "age": 57,
           "title": "Strategic Adviser & Independent Director",
           "yearBorn": 1963,
           "fiscalYear": 2021,
           "totalPay": 40000,
           "exercisedValue": 0,
           "unexercisedValue": 0
         },
         {
           "maxAge": 1,
           "name": "Mr. Mark J. Hawkins",
           "age": 61,
           "title": "Chief Financial Officer Emeritus",
           "yearBorn": 1959,
           "fiscalYear": 2021,
           "totalPay": 1914609,
           "exercisedValue": 10586233,
           "unexercisedValue": 0
         },
         {
           "maxAge": 1,
           "name": "Mr. Alexandre  Dayon",
           "age": 52,
           "title": "Pres & Chief Strategy Officer",
           "yearBorn": 1968,
           "fiscalYear": 2018,
           "exercisedValue": 0,
           "unexercisedValue": 0
         },
         {
           "maxAge": 1,
           "name": "Ms. Amy E. Weaver",
           "age": 52,
           "title": "Pres & CFO",
           "yearBorn": 1968,
           "exercisedValue": 0,
           "unexercisedValue": 0
         },
         {
           "maxAge": 1,
           "name": "Mr. Brent  Hyder",
           "age": 55,
           "title": "Pres & Chief People Officer",
           "yearBorn": 1965,
           "exercisedValue": 0,
           "unexercisedValue": 0
         }
       ],
       "auditRisk": 4,
       "boardRisk": 7,
       "compensationRisk": 4,
       "shareHolderRightsRisk": 3,
       "overallRisk": 3,
       "governanceEpochDate": "2021-07-01T00:00:00.000Z",
       "compensationAsOfEpochDate": "2021-12-31T00:00:00.000Z",
       "maxAge": 86400
     }
   }
 ]
 This may happen intermittently and you should catch errors appropriately.
 However:  1) if this recently started happening on every request for a symbol
 that used to work, Yahoo may have changed their API.  2) If this happens on
 every request for a symbol you've never used before, but not for other
 symbols, you've found an edge-case.  Please see if anyone has reported
 this previously:
   https://github.com/gadicc/node-yahoo-finance2/issues?q=is%3Aissue+Failed%20validation%3A%20%23%2Fdefinitions%2FQuoteSummaryResult
 or open a new issue (and mention the symbol):
   https://github.com/gadicc/node-yahoo-finance2/issues/new?labels=bug%2C+validation&template=validation.md&title=Failed%20validation%3A%20%23%2Fdefinitions%2FQuoteSummaryResult
 For information on how to turn off the above logging or skip these errors,
 see https://github.com/gadicc/node-yahoo-finance2/tree/devel/docs/validation.md.

Environment

Browser or Node: Node
Node version: v14.16.1
Npm version: 7.11.2
Library version: 1.14.4

@favasconcelos favasconcelos added bug Something isn't working validation Issues related to validation labels Sep 24, 2021
@gadicc gadicc closed this as completed in 5657df7 Sep 24, 2021
@gadicc
Copy link
Owner

gadicc commented Sep 24, 2021

Hey @favasconcelos, thanks for reporting! We now cover this case correctly (and also fixed a few other quoteSummary submodules where CRM wasn't passing) - will be released shortly.

gadicc pushed a commit that referenced this issue Sep 24, 2021
## [1.14.5](v1.14.4...v1.14.5) (2021-09-24)

### Bug Fixes

* **quoteSummary:** misc interface fixes (fixes [#295](#295)) ([5657df7](5657df7))
@gadicc
Copy link
Owner

gadicc commented Sep 24, 2021

🎉 This issue has been resolved in version 1.14.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released validation Issues related to validation
Projects
None yet
Development

No branches or pull requests

2 participants