Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"quote" function is not work for all US stock symbol #326

Closed
nikechanhk opened this issue Nov 13, 2021 · 5 comments
Closed

"quote" function is not work for all US stock symbol #326

nikechanhk opened this issue Nov 13, 2021 · 5 comments
Labels
bug Something isn't working released on @next released on @1.x released validation Issues related to validation

Comments

@nikechanhk
Copy link

Validation Error

Minimal Reproduction

It seems that all US stock symbol are not work since 11/11.
e.g.
await yahooFinance.quote('AAPL')
await yahooFinance.quote('ASML')
await yahooFinance.quote('TSCO')
etc...

However HK stock symbol have no problem

Symbol(s) that it happened for

All US symbol

Error Message

 yahoo-finance quote TSCO  

The following result did not validate with schema: #/definitions/QuoteResponseArray
[
  {
    instancePath: '/0',
    schemaPath: '#/definitions/QuoteCryptoCurrency/required',
    keyword: 'required',
    params: { missingProperty: 'circulatingSupply' },
    message: "must have required property 'circulatingSupply'",
    data: {
      language: 'en-US',
      region: 'US',
      quoteType: 'EQUITY',
      quoteSourceName: 'Delayed Quote',
      triggerable: true,
      currency: 'USD',
...
...
...

 }
]

This may happen intermittently and you should catch errors appropriately.
However:  1) if this recently started happening on every request for a symbol
that used to work, Yahoo may have changed their API.  2) If this happens on
every request for a symbol you've never used before, but not for other
symbols, you've found an edge-case.  Please see if anyone has reported
this previously:

  https://github.com/gadicc/node-yahoo-finance2/issues?q=is%3Aissue+Failed%20validation%3A%20%23%2Fdefinitions%2FQuoteResponseArray

or open a new issue (and mention the symbol):

  https://github.com/gadicc/node-yahoo-finance2/issues/new?labels=bug%2C+validation&template=validation.md&title=Failed%20validation%3A%20%23%2Fdefinitions%2FQuoteResponseArray

For information on how to turn off the above logging or skip these errors,
see https://github.com/gadicc/node-yahoo-finance2/tree/devel/docs/validation.md.

Exiting with FailedYahooValidationError: Failed Yahoo Schema validation

Environment

Browser or Node:
Node version (if applicable): v15.11.0
Npm version: v7.6.0
Browser verion (if applicable): N/A
Library version (e.g. 1.10.1): v1.14.6

Additional Context

@nikechanhk nikechanhk added bug Something isn't working validation Issues related to validation labels Nov 13, 2021
@gadicc gadicc closed this as completed in e425cd5 Nov 13, 2021
@gadicc
Copy link
Owner

gadicc commented Nov 13, 2021

Hey @nikechanhk, thanks for the report! We totally rely on these kinds of reports to make sure the library keeps working amidst changes on Yahoo's backend. This will be released shortly with the @next tag (v2 branch), there'll be an automated message here when that happens.

gadicc pushed a commit that referenced this issue Nov 13, 2021
## [2.0.1](v2.0.0...v2.0.1) (2021-11-13)

### Bug Fixes

* **quote:** allow optional pageViewGrowthWeekly (fixes [#326](#326)) ([e425cd5](e425cd5))
@gadicc
Copy link
Owner

gadicc commented Nov 13, 2021

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gadicc
Copy link
Owner

gadicc commented Nov 13, 2021

Also backported to 1.x branch since I guess this is quite an important fix. There'll be an automated message on this is a few more minutes too.

@gadicc
Copy link
Owner

gadicc commented Nov 13, 2021

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

gadicc pushed a commit that referenced this issue Nov 13, 2021
## [1.14.7](v1.14.6...v1.14.7) (2021-11-13)

### Bug Fixes

* **package:** have semantic-release recognize version branches ([38b6618](38b6618))
* **quote:** allow optional pageViewGrowthWeekly (fixes [#326](#326)) ([7d70ea1](7d70ea1))
@gadicc
Copy link
Owner

gadicc commented Nov 13, 2021

🎉 This issue has been resolved in version 1.14.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released on @next released on @1.x released validation Issues related to validation
Projects
None yet
Development

No branches or pull requests

2 participants