Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoc no longer works #337

Closed
gadicc opened this issue Nov 21, 2021 · 6 comments
Closed

autoc no longer works #337

gadicc opened this issue Nov 21, 2021 · 6 comments
Labels
bug Something isn't working released

Comments

@gadicc
Copy link
Owner

gadicc commented Nov 21, 2021 

$ yahoo-finance autoc GOOGL

Exiting with FetchError: invalid json response body at https://autoc.finance.yahoo.com/autoc?region=1&lang=en&query=GOOGL reason: Unexpected token < in JSON at position 0

Reason:

$ wget "https://autoc.finance.yahoo.com/autoc?region=1&lang=en&query=Goo"
--2021-11-21 15:33:12--  https://autoc.finance.yahoo.com/autoc?region=1&lang=en&query=Goo
SSL_INIT
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving autoc.finance.yahoo.com (autoc.finance.yahoo.com)... 87.248.100.208
Connecting to autoc.finance.yahoo.com (autoc.finance.yahoo.com)|87.248.100.208|:443... connected.
HTTP request sent, awaiting response... 404 Not Found on Accelerator
2021-11-21 15:33:12 ERROR 404: Not Found on Accelerator.

Looks like Yahoo have simply decommissioned their autoc server. The autocomplete on yahoo finance uses search under the hood anyways, so we should advise accordingly.
@gadicc gadicc added the bug Something isn't working label Nov 21, 2021
@gadicc
Copy link
Owner Author

gadicc commented Nov 22, 2021

Also mentioned in https://github.com/gadicc/node-yahoo-finance2/blob/devel/docs/modules/quote.md#query-options.

@gadicc gadicc closed this as completed in 0a6df7a Nov 23, 2021
@gadicc
Copy link
Owner Author

gadicc commented Dec 21, 2021

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mozeryansky
Copy link

Is there a way to mark the function deprecated or maybe delete the autoc code? I just ran into this issue and I was about to file a bug, good to know it's already known and addressed here.

@gadicc
Copy link
Owner Author

gadicc commented Feb 23, 2022

Err, yes. Not sure why I thought to update all the docs and leave all the code in. I think maybe I didn't mean to close the issue from the commit and then forgot about it after I did. Thanks for raising this!

@gadicc gadicc reopened this Feb 23, 2022
@gadicc gadicc closed this as completed in 99846ed Feb 23, 2022
gadicc pushed a commit that referenced this issue Feb 23, 2022
@semantic-release-bot
chore(release): 2.1.5 [skip ci]
1d4974c 
## [2.1.5](v2.1.4...v2.1.5) (2022-02-23)

### Bug Fixes

* **autoc:** throw error on use (fixes [#337](#337)) ([99846ed](99846ed))
* **deps:** bump ajv 8.9.0 -> 8.10.0, reconstruct yarn.lock ([#391](#391)) ([4370b44](4370b44))
* **historical,chart:** throw if period1===period2 (closes [#407](#407)) ([e120e55](e120e55))
* **moduleExec:** support assertSymbol field (closes [#406](#406)) ([1a05f59](1a05f59))
@gadicc
Copy link
Owner Author

gadicc commented Feb 23, 2022

🎉 This issue has been resolved in version 2.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mozeryansky
Copy link

Awesome, thanks! It's a great package, I'm glad it's active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gadicc @mozeryansky